deps: Switch from unmaintained term_size to terminal_size #4538
+46
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The term_size crate has been unmaintained for years. The RUSTSEC warning recommends terminal-size instead. The crate seems stable, and a review of the code shows it's safe to use and does what is expected. (no build.rs or similar, only calls to the relevant syscalls). Gets rid of a RUSTSEC warning.
syrusakbary
approved these changes
Apr 3, 2024
|
Needs to wait for #4539 . |
|
Currently we have some issues non related to this PR. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The term_size crate has been unmaintained for years.
The RUSTSEC warning recommends terminal-size instead.
The crate seems stable, and a review of the code shows it's safe to use
and does what is expected.
(no build.rs or similar, only calls to the relevant syscalls).
Gets rid of a RUSTSEC warning.
Description