Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix owner issues with app create #4537

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Fix owner issues with app create #4537

merged 2 commits into from
Apr 3, 2024

Conversation

ayys
Copy link
Member

@ayys ayys commented Apr 3, 2024

the owner field was being set to the same namespace as the package. This means
if the package is wasmer/hello then the owner becomes wasmer.

This PR also adds the owner field to app.yaml generated by wasmer app create

closes #4536

the owner field was being set to the same namespace as the package. This means
if the package is `wasmer/hello` then the owner becomes `wasmer`.

This PR also adds the owner field to app.yaml generated by `wasmer app create`
@ayys ayys requested a review from syrusakbary as a code owner April 3, 2024 11:24
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayys : need to update the tests with the new owner field.

@ayys ayys merged commit a597145 into master Apr 3, 2024
60 checks passed
@ayys ayys deleted the fix-app-create branch April 3, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure --owner flag works with wasmer app create
3 participants