New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix singlepass panic #4520

Merged

syrusakbary merged 1 commit into master from fix-singlepass-panic

Mar 25, 2024

Member

syrusakbary commented Mar 25, 2024

This PR partially fixes #4519 by protecting against panics in function finalization.

This PR does not fix the finalization error, just makes sure that singlepass no longer panics


          Fix singlepass panic. Partially fix #4519

ac81cde

syrusakbary merged commit 63cab7d into master

59 checks passed

syrusakbary deleted the fix-singlepass-panic branch

March 25, 2024 18:28

Contributor

theduke commented Mar 25, 2024

@syrusakbary we should add a test case that reproduces the issue to make sure we don't regress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet