Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental: Add interpreter support for Wasmer #4515

Merged
merged 113 commits into from
Oct 10, 2024
Merged

Experimental: Add interpreter support for Wasmer #4515

merged 113 commits into from
Oct 10, 2024

Conversation

syrusakbary
Copy link
Member

@syrusakbary syrusakbary commented Mar 25, 2024 •
edited
Loading

This PR adds support for running Wasm modules in interpreted mode (in this case, via WAMR).

Progress:

  • Make the baseline functionality work
  • Most of the examples work
  • Most of the test work
  • Integrate it into CI
  • Document the differences when using WAMR (for example: memory grow can't be called outside of the host)
  • Test this on iOS
  • Fix CLI (interpreter): Fix nested host calls #4971
  • Improve testing to test way more example and test cases

syrusakbary and others added 30 commits February 9, 2024 12:15
@syrusakbary
Refactored store
800adc0
@syrusakbary
Fix stores in JS/JSC
3c2172e
@syrusakbary
Fix engine reference
16818c2
@syrusakbary
Added AsEngineRef to the backend store
9c5412e
@syrusakbary
Fix JSC
021764d
@syrusakbary
Removed unused functions
5053e4f
@syrusakbary
Move sys vm into it’s own module. Improved externs
4a0bc39
@syrusakbary
Added maybe_as_store to the Store(AsEngineRef) for wasm-c-api compati…
27ae34d 
…bility
@syrusakbary
Removed unnecessary dobule error formatting
fff1b78
@syrusakbary
Got initial implementation of wamr working
a9a83c1
@syrusakbary
Trying to improve a bit the code
3ebdee1
@syrusakbary
Added CMakeLists
14bc922
@syrusakbary
Fix
a9b36f3
@syrusakbary
Push wasm.h (delete me after)
bd6ee49
@xdoardo
fix: remove unused imports
b43925b
@xdoardo
feat: valtype_to_type for more value types
ac84bbc
@xdoardo
feat: implement to extern for more kinds
384fdc4
@xdoardo
feat: add allow(...) in c_api module
3b79c4d
@xdoardo
feat: initial port of memory
921dafe
@xdoardo
fix: minor changes, remove prints
2e231b5
@xdoardo
feat: implement ty for Table
a009c2c
@xdoardo
feat: implement call for TypedFunction
844f9e7
@xdoardo
feat: implement callbacks for typed funcs
1c330fe
@xdoardo
fix: fmt + lint
d1bdecd
@xdoardo
fix: use git's submodule instead of manual clone
98e91bf
@xdoardo
fix: remove unused requirement from CMakeLists
5495003
@xdoardo
fix: pull submodule in build script
ef29757
@xdoardo
fix: allow unused
7413cc1
@xdoardo
fix: remove dependency on wat2wasm
500f234
@xdoardo
feat: implement new, get and set for globals
8ee56d8
@xdoardo xdoardo removed a link to an issue Jun 14, 2024
Interpreter: make Instance Sync #4758
Closed
@xdoardo
Copy link
Contributor

xdoardo commented Jun 14, 2024

Note: merging this PR closes issues #4496, #4495, #4494, #4493 and #4486 as well.

@xdoardo xdoardo mentioned this pull request Aug 8, 2024
Closed
syrusakbary
syrusakbary commented Aug 23, 2024
View reviewed changes
lib/api/src/c_api/mod.rs Outdated Show resolved Hide resolved
@xdoardo xdoardo added this to the v5.0 milestone Sep 2, 2024
@xdoardo xdoardo self-assigned this Sep 2, 2024
@xdoardo xdoardo removed a link to an issue Sep 3, 2024
Interpreter: use WAMR as a backend for the wasmer-c-api crate #4806
Closed
@syrusakbary syrusakbary mentioned this pull request Sep 10, 2024
Closed
@xdoardo xdoardo changed the base branch from main to release-5.0 September 23, 2024 14:30
@xdoardo xdoardo mentioned this pull request Oct 7, 2024
Merged
@syrusakbary
Copy link
Member Author

Merging this into 5.0 so then we can review and merge wasmi and v8

@syrusakbary syrusakbary merged commit 8e95936 into release-5.0 Oct 10, 2024
62 of 63 checks passed
@syrusakbary syrusakbary deleted the wamr branch October 10, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xdoardo xdoardo xdoardo left review comments

Assignees

@xdoardo xdoardo

Labels
project-holochain
Projects
None yet
Milestone
v5.0
2 participants
@syrusakbary @xdoardo