Fix for snapshots in certain use cases #4514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theduke
reviewed
Mar 25, 2024
|
|
||
| // Install the ctrl-c handler | ||
| #[cfg(feature = "ctrlc")] | ||
| if attach_ctrl_c { |
There was a problem hiding this comment.
Putting this logic here in the runner seems a bit hacky to me, can't we do this on the outside without having to smush it into the runner?
Isn't it enough to be in the CLI?
There was a problem hiding this comment.
It's also in the runner (which is in the CLI) - however there is another code path left in the CLI which does not use the runner and hence comes down this path. The fix is to unify the code of both into one, that's quite a bit more work than this patch.
theduke
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.