Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Upgrade edge-schema to 0.0.3 #4507

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

theduke
Copy link
Contributor

@theduke theduke commented Mar 21, 2024

Needed for some upstream schema changes.

@theduke theduke requested a review from syrusakbary as a code owner March 21, 2024 13:36
@theduke theduke requested a review from ayys March 21, 2024 13:36
Copy link
Member

@ayys ayys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just seen edge-schema in Cargo.lock and we are actually having 3 versions of edge-schema!

We should make edge-schema be a workspace dependency (since is already used in wasmer-backend-api and wasmer-cli) and also update edge-util to use the latest edge-schema

@theduke theduke force-pushed the deps-upgrade-edge-schema branch 2 times, most recently from 0123806 to 1ba1920 Compare March 21, 2024 13:46
@theduke
Copy link
Contributor Author

theduke commented Mar 21, 2024

@syrusakbary fixed.

Needed for some upstream schema changes.
@theduke theduke force-pushed the deps-upgrade-edge-schema branch from 1ba1920 to c72f6c9 Compare March 21, 2024 13:52
@theduke theduke enabled auto-merge (rebase) March 21, 2024 14:05
@theduke theduke merged commit 064bb79 into master Mar 21, 2024
54 of 59 checks passed
@theduke theduke deleted the deps-upgrade-edge-schema branch March 21, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants