DProxy #4462
Merged
DProxy #4462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onger crash the system
theduke
reviewed
Feb 26, 2024
|
@john-sharratt we should tackle the clean abstractions now rather than punting it to someone else in the upcoming refactor. As is this adds fresh complications to the refactor that will be hard to untangle. |
|
Tackling the abstractions now... is the refactor. That's the whole problem in the first place, this PR is not appropriate for that work as its significant and makes this PR too big |
theduke
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Journal support for pause and resume of a WASIX compiled HTTP based server
Fixes for various aspects that were not working properly in the Jounral