Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): Add missing output in "app get" command and fix output of "app info" #4460

Merged
merged 2 commits into from
Feb 25, 2024
Merged

fix(cli): Add missing output in "app get" command and fix output of "app info" #4460

merged 2 commits into from
Feb 25, 2024

Conversation

theduke
Copy link
Contributor

@theduke theduke commented Feb 21, 2024 •
edited
Loading

  • missing println!() in AppGet - was probably lost in the recent refactor
  • fixed double output in AppInfo
  • added namespace to "app info"

@theduke theduke requested a review from syrusakbary as a code owner February 21, 2024 12:13
@theduke theduke changed the title fix(cli): Add missing output in "app get" command fix(cli): Add missing output in "app get" command and fix output of "app info" Feb 21, 2024
@theduke theduke requested a review from maminrayej February 21, 2024 12:23
@theduke theduke enabled auto-merge (rebase) February 21, 2024 20:58
@theduke theduke merged commit 2643389 into master Feb 25, 2024
59 checks passed
@theduke theduke deleted the fix-cli-app-get branch February 25, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maminrayej maminrayej maminrayej approved these changes

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theduke @maminrayej