Fix note about unaligned references in WasmRef
docs
#4444
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrary to the current docs,
WasmRef
is not safe for unaligned references. This PR adjusts the docs.Here's an example that shows the problem:
It would be possible to support this using
write_unaligned
, but that would require some refactoring, since it needs to be kept a pointer and not converted to a reference, as is currently done inWasmRefAccess::new
.