Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust toolchain to 1.73 #4434

Merged
merged 10 commits into from
Feb 7, 2024
Merged

Update Rust toolchain to 1.73 #4434

merged 10 commits into from
Feb 7, 2024

Conversation

syrusakbary
Copy link
Member

We should be normally 1-2 versions behind than the official version.

I got an error when trying to compile Wasmer as another crate was failing compilation. This fixes it

@theduke theduke force-pushed the update-rust-toolchain branch from caff78b to 9618618 Compare February 7, 2024 13:06
@syrusakbary
Copy link
Member Author

The two failing tests are flaky, nothing to do with this PR

@syrusakbary syrusakbary merged commit bcebad4 into master Feb 7, 2024
46 of 48 checks passed
@syrusakbary syrusakbary deleted the update-rust-toolchain branch February 7, 2024 15:47
@ayys
Copy link
Member

ayys commented Feb 12, 2024

This broke the schema validation CI on registry with error

cargo fmt --all -- --check
error: 'cargo-fmt' is not installed for the toolchain '1.73-x86_64-unknown-linux-gnu'
To install, run `rustup component add rustfmt --toolchain 1.73-x86_64-unknown-linux-gnu`

fix was simple though, just updated the toolchain being installed as part of the CI

      - name: Install Rust
        uses: dtolnay/rust-toolchain@stable
        with:
-          toolchain: "1.70"
+          toolchain: "1.73"
          components: rustfmt, clippy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants