Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Notsup for absolute symlinks instead of panicking #4429

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Return Notsup for absolute symlinks instead of panicking #4429

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6e5726
Return Notsup for absolute symlinks instead of panicking
boomshroom Feb 1, 2024
ddc4c74
Merge branch 'master' into patch-1
theduke Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/wasix/src/fs/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,7 +930,8 @@ impl WasiFs {
let (pre_open_dir_fd, relative_path) = if link_value.is_relative() {
self.path_into_pre_open_and_relative_path(&file)?
} else {
unimplemented!("Absolute symlinks are not yet supported");
tracing::error!("Absolute symlinks are not yet supported");
theduke marked this conversation as resolved.
Show resolved Hide resolved
return Err(Errno::Notsup);
};
loop_for_symlink = true;
symlink_count += 1;
Expand Down
Loading