Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to build the package before publishing it #4428

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

maminrayej
Copy link
Contributor

@maminrayej maminrayej commented Jan 31, 2024

This PR adds a preliminary step to wasmer publish that tries to build the package before publishing it. As a bonus, wasmer package build now has the --check flag which only checks whether the package could be built or not.

Related to #4288 and this comment.

Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@syrusakbary syrusakbary merged commit 7349e1c into master Feb 1, 2024
52 checks passed
@syrusakbary syrusakbary deleted the build-before-publish branch February 1, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants