Allow users to provide custom host functions to WasiRunner and WasiEnvBuilder
#4403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 16, 2024 18:35
…defined host functions to a WASIX instance
…self` builder methods
Michael-F-Bryan
force-pushed
the
wasi-runner-custom-imports
branch
from
0426d8f to
5727d53
Compare
maminrayej
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
WasiEnvBuilderandWasiRunnerto allow providing custom imports that will be used when instantiating a WASIX module.I've also re-worked the
WasiRunner's builder methods to all follow thefn with_xxx(&mut self, ...) -> &mut Selfpattern. TheRunnertrait'srun_command()method already takes&mut self, so that means people can doWasiRunner::new().with_args(...).run_command(...)without needing to introduce an intermediate variable. This should be more ergonomic than forcing people to builder methods that either consume or setters that don't allow chaining.