Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore append when truncate is set #4394

Merged
merged 2 commits into from
Jan 9, 2024
Merged

ignore append when truncate is set #4394

merged 2 commits into from
Jan 9, 2024

Conversation

maminrayej
Copy link
Contributor

Resolves #4376.

Arshia001
Arshia001 approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@Arshia001 Arshia001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maminrayej maminrayej enabled auto-merge January 9, 2024 10:59
@maminrayej maminrayej disabled auto-merge January 9, 2024 10:59
@maminrayej maminrayej merged commit 214b76b into master Jan 9, 2024
52 checks passed
@maminrayej maminrayej deleted the allow-all-open-flags branch January 9, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arshia001 Arshia001 Arshia001 approved these changes

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot open a file with O_TRUNC and O_APPEND
3 participants
@maminrayej @syrusakbary @Arshia001