fix: Don't log the FmtSpan::ENTER event because it generates unnecessary logs
#4387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-F-Bryan
requested review from
syrusakbary,
theduke,
Arshia001 and
john-sharratt
Michael-F-Bryan
changed the title
FmtSpan::ENTER event because it generates unnece…FmtSpan::ENTER event because it generates unnecessary logs
Arshia001
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like @john-sharratt added the
FmtSpan::ENTERevent while debuggingpoll_oneoffin a7f4460, but it was never removed afterwards so it ended up in the 4.2.4 release.We don't want to be logging
FmtSpan::ENTERbecause it means any async function annotated with#[tracing::instrument]will emit a log message every time the future is polled. Considering each read from a socket will poll the future again, that means you can easily end up with tens of thousands of unnecessary log entries printed to the screen when running withRUST_LOG=wasmer_wasix=debug.