feat(api): Add SharedMemoryHandle #4385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theduke
force-pushed
the
issue-4383-wasix-atomics
branch
2 times, most recently
from
6ff03c0 to
95bcf23
Compare
|
Pushed a small change that makes the handle only hold a weak reference to the underlying atomics handler to avoid prolonging the memory lifetime. |
theduke
force-pushed
the
issue-4383-wasix-atomics
branch
2 times, most recently
from
cb8a1e7 to
1f8d888
Compare
theduke
force-pushed
the
issue-4383-wasix-atomics
branch
from
8e8a99b to
49ca321
Compare
Allows to trigger atomics related operations on a memory that supports interacting with the atomics layer. It adds a shared_handle() method to `Memory`. Right now only final operations are exposed that wake up all atomic waiters, and that allow disabling atomics. This is required for forceful shutdown of instances that keep hot-looping on atomics, and will be used from WASIX.
Prevents prolonging the thread conditions lifetime unneccessarily.
Provide a wrapper around Memory that also holds the SharedMemoryOps.
theduke
force-pushed
the
issue-4383-wasix-atomics
branch
from
49ca321 to
c8df06a
Compare
syrusakbary
reviewed
Jan 22, 2024
syrusakbary
reviewed
Jan 22, 2024
syrusakbary
approved these changes
Jan 22, 2024
theduke
force-pushed
the
issue-4383-wasix-atomics
branch
from
577cab8 to
d1d87c4
Compare
theduke
force-pushed
the
issue-4383-wasix-atomics
branch
from
3191b0b to
5efe9bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to trigger atomics related operations on a memory that supports
interacting with the atomics layer though a shared handle.
Note that this needs to be a separate handle that is not a store reference, because it needs to be accessible while an instance is executing.
Right now only final operations are exposed that wake up all atomic
waiters, and that allow disabling atomics.
This is required for forceful shutdown of instances that keep
hot-looping on atomics, and will be used from WASIX.
Part of #4383