Use nanoseconds in filestat for directories
#4359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yagehu
force-pushed
the
yagehu/filestat-times
branch
from
9059f61 to
81b721e
Compare
yagehu
commented
Dec 17, 2023
This commit fixes the `filestat` type which contains three timestamps. Per [WASI spec], they should be in nanoseconds. This is only a problem for directories. [WASI spec]: https://github.com/WebAssembly/WASI/blob/main/legacy/preview1/docs.md#-timestamp-u64 Signed-off-by: Yage Hu <[email protected]>
theduke
force-pushed
the
yagehu/filestat-times
branch
from
81b721e to
d2f2d05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the
filestattype which contains three timestamps. Per WASI spec, they should be in nanoseconds. This is only a problem for directories.fixes #4358