Fix the virtual_fs::StaticFile implementation
#4355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 15, 2023 00:11
… cursor fix: Trying to modify a `virtual_fs::StaticFile` now returns a permission error instead of silently doing nothing
…n use an `OwnedBuffer` while not breaking users of `StaticFile::new()`
theduke
approved these changes
Dec 14, 2023
This was referenced Dec 14, 2023
Michael-F-Bryan
pushed a commit
to wasmerio/wasmer-js
that referenced
this pull request
Dec 15, 2023
…up-front-seems-to-always-read-the-same-bytes Pick up wasmerio/wasmer#4355 to fix stdin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AsyncReadimplementation forvirtual_fs::StaticFilenever updates its internal cursor, so reading from aStaticFilewould always yield the same bytes without ever encountering an EOF.I've fixed this by throwing away a lot of the custom code and just making
StaticFilea thin wrapper aroundstd::io::Cursor. I've also updated the other filesystem trait implementations so trying to modify avirtual_fs::StaticFilenow returns a permission error instead of silently doing nothing.Fixes wasmerio/wasmer-js#366