Wait for webc, bindings, exe generation during package-publish with --wait flag
#4352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
It looks good on my side, although I think it will be better for @Michael-F-Bryan to review it
ayys
commented
Dec 18, 2023
ayys
force-pushed
the
improve-publish-cmd
branch
from
d70fca9 to
1c52e30
Compare
ayys
force-pushed
the
improve-publish-cmd
branch
from
12914f2 to
232a2f4
Compare
Update graphql-client version, update `tokio` version, and add `graphql-ws-client` and `tokio-tungstenite` as new dependencies.
when the `--wait` flag is specified, subscribe to the `packageVersionReady` subscription and wait for webc, bindings, exes to be generated.
Michael-F-Bryan
force-pushed
the
improve-publish-cmd
branch
from
232a2f4 to
2b272d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
wasmer publishis called with the--waitflag, it now triggers a graphql subscription that waits for webc generation, language bindings generation and native executables generation.Note: This feature is only available on dev right now (https://registry.wasmer.wtf/graphql)This feature is on deployed on prod backend.
Screen.Recording.2023-12-11.at.1.16.10.PM.mov