Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the middle of my investigations for improving startup time, I encountered issue #3851 in one of the comments.
This fix isn't ideal since it uses the
tokio
thread pool instead of the pool inTokioTaskManager
. I couldn't figure out how to design a trait that is both object-safe, and is able to model thespawn_await
function that I had in mind properly. This is the best that I came up with:which isn't object-safe.
I could clone the
TokioTaskManager
directly intoFileSystemCache
, but I was not sure about it.