Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix visibility validation to work when publishing a new package #4331

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Fix visibility validation to work when publishing a new package #4331

merged 3 commits into from
Nov 28, 2023

Conversation

Michael-F-Bryan
Copy link
Contributor

Fixes #4329.

Arshia001
Arshia001 approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@Arshia001 Arshia001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Michael-F-Bryan Michael-F-Bryan merged commit 476d95d into master Nov 28, 2023
52 of 53 checks passed
@Michael-F-Bryan Michael-F-Bryan deleted the validate-nonexistent-packages branch November 28, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arshia001 Arshia001 Arshia001 approved these changes

@theduke theduke Awaiting requested review from theduke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI: wasmer publish fails for private packages that don't exist yet
2 participants
@Michael-F-Bryan @Arshia001