-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --wait
and --timeout
flags to wamer publish
#4328
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wait flag gets propagated to the backend via graphql params. This makes it so publish package waits for webc generation too pass.
This makes it much more readable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a mostly straightforward addition.
I've added some comments for how we could make the --timeout
argument more user-friendly (i.e. let them do --timeout=60s
), but don't see any issues.
Thanks for cleaning up the wasmer-registry
code, by the way!
Michael-F-Bryan
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--wait
flagRationale: When a large package is published, the user has to wait for a while to
be able to use it. This is because the webc of the package is not available on
the registry until the package is fully processed.
The registry now supports passing a wait flag to the publish query. This will
cause the query to wait until the webc of the package is available on the
registry before exiting. By default, this is set to false (for backwards
compatibility), and the
--wait
flag on the CLI enables it.The
--timeout
flagRationale: When publishing a large package with the
--wait
flag - it may take a longtime.
The
--timeout
flag can be used to set the timeout for http requests made whilepublishing the package. This is important because processing large webc files
may take a while. The default timeout is set to 30 seconds, but can be increased
if necessary (e.g. when publishing large packages).
Example usage:
Since the package is immediately available, the above command is possible.