Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --wait and --timeout flags to wamer publish #4328

Merged
merged 10 commits into from
Nov 28, 2023
Merged

Conversation

ayys
Copy link
Member

@ayys ayys commented Nov 27, 2023

The --wait flag

Rationale: When a large package is published, the user has to wait for a while to
be able to use it. This is because the webc of the package is not available on
the registry until the package is fully processed.

The registry now supports passing a wait flag to the publish query. This will
cause the query to wait until the webc of the package is available on the
registry before exiting. By default, this is set to false (for backwards
compatibility), and the --wait flag on the CLI enables it.

The --timeout flag

Rationale: When publishing a large package with the --wait flag - it may take a long
time.

The --timeout flag can be used to set the timeout for http requests made while
publishing the package. This is important because processing large webc files
may take a while. The default timeout is set to 30 seconds, but can be increased
if necessary (e.g. when publishing large packages).

Example usage:

wasmer publish --wait --timeout 120s && wasmer run <package-name>

Since the package is immediately available, the above command is possible.

@ayys ayys requested a review from syrusakbary as a code owner November 27, 2023 09:42
@ayys ayys marked this pull request as draft November 27, 2023 09:45
Copy link
Contributor

@Michael-F-Bryan Michael-F-Bryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a mostly straightforward addition.

I've added some comments for how we could make the --timeout argument more user-friendly (i.e. let them do --timeout=60s), but don't see any issues.

Thanks for cleaning up the wasmer-registry code, by the way!

lib/cli/src/commands/publish.rs Outdated Show resolved Hide resolved
lib/registry/src/publish.rs Show resolved Hide resolved
lib/registry/src/publish.rs Outdated Show resolved Hide resolved
lib/cli/src/commands/publish.rs Outdated Show resolved Hide resolved
@ayys ayys marked this pull request as ready for review November 28, 2023 13:57
@ayys ayys merged commit e643873 into master Nov 28, 2023
53 checks passed
@ayys ayys deleted the packge-publish-wait-flag branch November 28, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants