fix: Prevent panicking in VirtualTaskManagerExt::spawn_and_block_on #4322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helper method previously would panic if the inner async task failed to send a result, instead of returning an error that can be handled. It also: * used an mpsc channel. a oneshot channel is better here * used the InlineWaker to wait for the result, which is also redundant because tokio channels have sync receive methods
Michael-F-Bryan
approved these changes
Nov 23, 2023
syrusakbary
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helper method previously would panic if the inner async task failed
to send a result, instead of returning an error that can be handled.
It also:
because tokio channels have sync receive methods