Bump min enumset version to 1.1.0 #4317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The symbol `enumset::__internal::EnumSetTypeRepr` used in types was only made public in 1.1.0: Lymia/enumset@v1.0.13...v1.1.0
syrusakbary
requested changes
Nov 20, 2023
There was a problem hiding this comment.
Hey @webmaster128 , I think it may be a better idea to set enumset as a workspace dependency, and then just do:
enumset.workspace = true
|
Sure. Do you know what happens to |
syrusakbary
approved these changes
Nov 20, 2023
webmaster128
added a commit
to CosmWasm/cosmwasm
that referenced
this pull request
Jan 15, 2024
Wasmer requires enumset 1.1.0 now (wasmerio/wasmer#4317)
webmaster128
added a commit
to CosmWasm/cosmwasm
that referenced
this pull request
Jan 15, 2024
Wasmer requires enumset 1.1.0 now (wasmerio/wasmer#4317)
webmaster128
added a commit
to CosmWasm/cosmwasm
that referenced
this pull request
Jan 16, 2024
Wasmer requires enumset 1.1.0 now (wasmerio/wasmer#4317)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The symbol
enumset::__internal::EnumSetTypeReprused in wasmer-types was only made public in 1.1.0:Lymia/enumset@v1.0.13...v1.1.0
In order to ensure a project embedding Wasmer does not use incompatible enumset versions ^1.0.0, < 1.1.0 we should bump the version here to the actual min required version.