Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for the non-flushing of file descriptors and a nasty deadlock #4307

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Fix for the non-flushing of file descriptors and a nasty deadlock #4307

merged 1 commit into from
Nov 28, 2023

Conversation

john-sharratt
Copy link
Contributor

@john-sharratt john-sharratt commented Nov 13, 2023 •
edited by theduke
Loading

Closes #4303

@john-sharratt john-sharratt mentioned this pull request Nov 13, 2023
Closed
theduke
theduke requested changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add a regression test here that validates the problem from the other PR does not re-occur.

@theduke theduke force-pushed the fix-for-4293-fix-for-closing-fds branch from d9e15c6 to a20bea5 Compare November 28, 2023 10:14
@theduke theduke merged commit 4fab39c into master Nov 28, 2023
53 of 54 checks passed
@theduke theduke deleted the fix-for-4293-fix-for-closing-fds branch November 28, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theduke theduke theduke approved these changes

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python (subprocess?) gets blocked on latest master
3 participants
@john-sharratt @syrusakbary @theduke