Allow WasiRunner to mount FileSystem instances
#4302
Merged
+351
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-F-Bryan
force-pushed
the
wasi-runner-mount-fs-instances
branch
from
2bc0a1f to
fc8c6a7
Compare
Michael-F-Bryan
force-pushed
the
wasi-runner-mount-fs-instances
branch
from
c1cdff0 to
29746d1
Compare
Michael-F-Bryan
force-pushed
the
wasi-runner-mount-fs-instances
branch
4 times, most recently
from
2ee9b56 to
d2ac6c2
Compare
Michael-F-Bryan
force-pushed
the
wasi-runner-mount-fs-instances
branch
from
d2ac6c2 to
f9bf1c4
Compare
Michael-F-Bryan
force-pushed
the
wasi-runner-mount-fs-instances
branch
from
f9bf1c4 to
d37aa0d
Compare
|
@syrusakbary or @theduke can you review this? It's the last thing Wasmer JS needs before we can make it use |
theduke
reviewed
Jan 5, 2024
added 2 commits
January 10, 2024 16:59
… as directories on the host system
Michael-F-Bryan
force-pushed
the
wasi-runner-mount-fs-instances
branch
from
d37aa0d to
c9eaebe
Compare
added 5 commits
January 10, 2024 17:16
theduke
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of wasmerio/wasmer-js#334 we need the ability to mount entire
FileSysteminstances at a particular point in the WASIX instance's filesystem.I've added an adaptor so the existing
map_directory()methods for mapping a directory on the host filesystem goes through this newmount()mechanism.