Use authentication when running a package #4300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-F-Bryan
force-pushed
the
michael/run-2-use-authentication-when-running-a-package
branch
from
bca53d2 to
cbef0c4
Compare
theduke
reviewed
Nov 8, 2023
Michael-F-Bryan
force-pushed
the
michael/run-2-use-authentication-when-running-a-package
branch
from
e279970 to
a63e75c
Compare
added 11 commits
November 21, 2023 18:03
…Loader's public API to be more builder-like
…ageLoader over to resolve tokens from the URL hostname
Michael-F-Bryan
force-pushed
the
michael/run-2-use-authentication-when-running-a-package
branch
2 times, most recently
from
a63e75c to
2fec91a
Compare
Michael-F-Bryan
deleted the
michael/run-2-use-authentication-when-running-a-package
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of private packages and #4247, we want to make sure API tokens are sent to the backend when doing
wasmer run some/private-package.We'd like the CLI to automatically figure out which token to use while not sending API tokens to random endpoints, so updated
WapmSource(the component that queries the Wasmer registry when looking up packages) to accept an API token for its registry and modifiedBuiltinPackageLoader(the component for downloading those packages) so it has a hashmap of hostnames to API tokens that it will consult when downloading a*.webcfile.