Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminate after flushing file descriptors #4294

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

john-sharratt
Copy link
Contributor

This patch will modify the behavior of a closing WASM process so that it only sends the termination signal after stdout and stderr are flushed.

@syrusakbary
Copy link
Member

We need this: Because WCGI will stream the response waiting for either of these conditions:

  1. the stdout to finish streaming
  2. the process to exit

So if we exit the process before we finish the streaming there is a race condition where the data could be truncated

@syrusakbary syrusakbary enabled auto-merge November 6, 2023 02:16
@syrusakbary syrusakbary merged commit 3c0ff3b into master Nov 6, 2023
53 checks passed
@syrusakbary syrusakbary deleted the terminate-after-flush branch November 6, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants