Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update memoffset to 0.9.0 #4273

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Update memoffset to 0.9.0 #4273

merged 2 commits into from
Nov 2, 2023

Conversation

joshlf
Copy link
Contributor

@joshlf joshlf commented Oct 23, 2023

Implemented as part of rust-lang/rust#111839

Description

@alex
Copy link

alex commented Oct 23, 2023

There's lockfiles that need to be udpated

@joshlf
Copy link
Contributor Author

joshlf commented Oct 23, 2023

There's lockfiles that need to be udpated

Ooops, thanks! Ran cargo update.

@joshlf
Copy link
Contributor Author

joshlf commented Oct 23, 2023

Not sure what's going on with this job; when I run locally, it succeeds:

$ cargo +nightly-2023-05-25 check --verbose --locked
    Finished dev [unoptimized + debuginfo] target(s) in 0.30s

@joshlf
Copy link
Contributor Author

joshlf commented Oct 23, 2023

Any advice on what to do about this failure in this job?

---- test_imported_function_env stdout ----
Error: Error { kind: Wast(Error { inner: ErrorInner { text: Some(Text { line: 10, col: 9, snippet: "        (set_local $x (i32.sub (get_local $x) (i32.const 1)))" }), file: None, span: Span { offset: 356 }, kind: Custom("unknown operator or unexpected token") } }) }

Same with this failure in this job:

---- metering::complex_loop::cranelift::universal stdout ----
thread 'metering::complex_loop::cranelift::universal' panicked at 'called `Result::unwrap()` on an `Err` value: Wasm(Generic("Error when converting wat: unknown operator or unexpected token\n     --> <anon>:9:13\n      |\n    9 |             set_local $l0\n      |             ^"))', tests/compilers/metering.rs:159:43
stack backtrace:
   0: rust_begin_unwind
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/std/src/panicking.rs:578:5
   1: core::panicking::panic_fmt
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/panicking.rs:67:14
   2: core::result::unwrap_failed
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/result.rs:1687:5
   3: compilers::metering::complex_loop::complex_loop
   4: compilers::metering::complex_loop::cranelift::universal
   5: core::ops::function::FnOnce::call_once
   6: core::ops::function::FnOnce::call_once
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

---- metering::complex_loop::llvm::universal stdout ----
thread 'metering::complex_loop::llvm::universal' panicked at 'called `Result::unwrap()` on an `Err` value: Wasm(Generic("Error when converting wat: unknown operator or unexpected token\n     --> <anon>:9:13\n      |\n    9 |             set_local $l0\n      |             ^"))', tests/compilers/metering.rs:159:43
stack backtrace:
   0: rust_begin_unwind
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/std/src/panicking.rs:578:5
   1: core::panicking::panic_fmt
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/panicking.rs:67:14
   2: core::result::unwrap_failed
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/result.rs:1687:5
   3: compilers::metering::complex_loop::complex_loop
   4: compilers::metering::complex_loop::llvm::universal
   5: core::ops::function::FnOnce::call_once
   6: core::ops::function::FnOnce::call_once
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

---- metering::complex_loop::singlepass::universal stdout ----
thread 'metering::complex_loop::singlepass::universal' panicked at 'called `Result::unwrap()` on an `Err` value: Wasm(Generic("Error when converting wat: unknown operator or unexpected token\n     --> <anon>:9:13\n      |\n    9 |             set_local $l0\n      |             ^"))', tests/compilers/metering.rs:159:43
stack backtrace:
   0: rust_begin_unwind
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/std/src/panicking.rs:578:5
   1: core::panicking::panic_fmt
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/panicking.rs:67:14
   2: core::result::unwrap_failed
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/result.rs:1687:5
   3: compilers::metering::complex_loop::complex_loop
   4: compilers::metering::complex_loop::singlepass::universal
   5: core::ops::function::FnOnce::call_once
   6: core::ops::function::FnOnce::call_once
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/ops/function.rs:250:5

@syrusakbary
Copy link
Member

The errors seem unrelated to the PR. Not sure why they are failing exactly. Rerunning the tests again

@theduke
Copy link
Contributor

theduke commented Nov 2, 2023

I pushed a commit lifting memoffset into a workspace dependency to avoid duplication.

@theduke theduke closed this Nov 2, 2023
@theduke theduke reopened this Nov 2, 2023
@theduke theduke enabled auto-merge (rebase) November 2, 2023 12:20
@theduke theduke merged commit dcc9cc1 into wasmerio:master Nov 2, 2023
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants