fix: Fix async runtime mismatch in virtual "wasmer run" command #4272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The virtual "wasmer run" command available in wasix was switched to a inline waker for resolving the future, but it calls BinaryPackage::from_registry, which needs to run in a tokio runtime, due to doing web requests for package retrieval. Easily fixed by delegating to the main runtime. Closes #4269
theduke
force-pushed
the
issue-4269-fix-virtual-wasmer-run-command
branch
from
535abe3 to
4689b2f
Compare
Michael-F-Bryan
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The virtual "wasmer run" command available in wasix was switched to a
inline waker for resolving the future, but it calls
BinaryPackage::from_registry, which needs to run in a tokio runtime, due
to doing web requests for package retrieval.
Easily fixed by delegating to the main runtime.
Closes #4269