Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use write instead of send for pipe, to accomodate socketpair #4224

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Use write instead of send for pipe, to accomodate socketpair #4224

merged 3 commits into from
Sep 22, 2023

Conversation

ptitSeb
Copy link
Contributor

@ptitSeb ptitSeb commented Sep 21, 2023

Use write instead of send for pipe, to accomodate socketpair.

Because C socketpair use fd_pipe to create the pair, waist pipe will need to handle sock_send

@ptitSeb ptitSeb marked this pull request as ready for review September 22, 2023 14:32
@ptitSeb ptitSeb merged commit 85a3551 into master Sep 22, 2023
53 checks passed
@ptitSeb ptitSeb deleted the fix_pipe_send branch September 22, 2023 18:17
@Michael-F-Bryan Michael-F-Bryan mentioned this pull request Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary left review comments

@Michael-F-Bryan Michael-F-Bryan Michael-F-Bryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ptitSeb @syrusakbary @Michael-F-Bryan