Ability to detect a tainted instance #4220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When registering a handler twice it would fail the second time - DONTROUTE was being set which basically breaks all networking - Poll was registered on the wrong events (this was introduced in this patch earlier rather than from mainline) - The writable event was being triggered at the wrong time (i.e. either too early or two late) - converted to a non-blocking poll call instead - Added a unit test so that this doesn't happen again
… compiler version
- Fixed the windows build issues - Fixed some linting errors - Fixed some epoll backwards compatible issues - Implemented a unit tests for epoll to google
theduke
approved these changes
Sep 18, 2023
Michael-F-Bryan
suggested changes
Sep 19, 2023
There was a problem hiding this comment.
You'll generally want to share a Runtime to reuse the same thread pool, any connections that may still be held open by the HTTP client, in-memory caches, and so on.
With that in mind, I think we need to include some sort of ID (or a reference to the wasmer::Instance) in on_taint() that allows the runtime to know which instance became tainted. Otherwise we've just got a "something went wrong" callback and the only way to know which instance became tainted is through context, which is pretty brittle.
|
We'll keep this open for now, but ideally we should use proper signal propagation to implement this properly (based on @theduke feedback) |
auto-merge was automatically disabled
March 11, 2024 12:14
Rebase failed
theduke
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to go in first
#4211