Ignore fd_close(3) to avoid breaking POSIX programs that blindly close all file descriptors
#4215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… close all file descriptors
Arshia001
approved these changes
Sep 14, 2023
ptitSeb
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a hack that ignores
fd_close(3)so POSIX programs that blindly close all file descriptors other than stdin/stdout/stderr don't lock themselves out of the filesystem.See @ptitSeb's troubleshooting on Slack for more context.
It's pretty difficult to write tests for WASIX syscalls at the moment, so I'm just going to test manually.