Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove StdioMode::Reserved variant #4206

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Remove StdioMode::Reserved variant #4206

merged 1 commit into from
Oct 2, 2023

Conversation

g-bartoszek
Copy link
Contributor

Description

Removes redundant StdioMode variant to make it match the wasix-abi-rust definition.

theduke
theduke approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This alligns the defifnitions with the current state in the Rust wasix crate and the libc, so this is what we want.

@theduke theduke enabled auto-merge (rebase) September 8, 2023 09:53
@syrusakbary syrusakbary disabled auto-merge October 2, 2023 17:37
@syrusakbary syrusakbary merged commit afaa023 into wasmerio:master Oct 2, 2023
52 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theduke theduke theduke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@g-bartoszek @theduke @syrusakbary