Fix File System Merging Problems #4205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the EmptyFileSystem read_dir() implementation to always return an empty iterator when trying to read the root path "/". This is done because some code paths expect the root to always be readable. This also makes sense theoretically, because an empty file system should still be readable, just not contain any files.
theduke
force-pushed
the
fix-filesystem-merging
branch
from
88d785c to
7768ed7
Compare
ptitSeb
approved these changes
Sep 5, 2023
Tests merging as done in the `Console`.
theduke
force-pushed
the
fix-filesystem-merging
branch
from
7768ed7 to
6f0b022
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Prevent invalid file system merging errors
This commit changes the EmptyFileSystem read_dir() and metadata() implementation
to always return an empty stub when trying to read the root path "/".
This is done because some code paths expect the root to always be
readable.
This also makes sense thematically, because an empty file system should
still be readable, just not contain any files.
This fixes bugs related to file system union/merging logic.
Also adds a regression test.