Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sockets #4193

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Fix sockets #4193

merged 2 commits into from
Sep 6, 2023

Conversation

Arshia001
Copy link
Member

A couple of small fixes to sockets:

  • Fixed endianness issue when deserializing IPv6 addresses that caused swapped bytes in each u16.
  • Fixed receiving data from UDP sockets that have not been connected to a remote socket (i.e. server sockets).

@ptitSeb
Copy link
Contributor

ptitSeb commented Aug 31, 2023

This seems very similar to #4166

Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it would be lovely if we had asnapshot tests for this...

EG: a simple UDP server and client that exchange a few packets , once in Rust and once in libc.

Goes a long way in preventing regressions.

lib/wasix/src/net/mod.rs Show resolved Hide resolved
@Arshia001
Copy link
Member Author

@theduke the problem is that UDP is still not really working. There's something wrong with either binding or receiving, but I haven't figured out exactly what it is yet.

@theduke
Copy link
Contributor

theduke commented Aug 31, 2023

@theduke the problem is that UDP is still not really working. There's something wrong with either binding or receiving, but I haven't figured out exactly what it is yet.

Even more important to have a test then.

@Arshia001
Copy link
Member Author

Absolutely, as soon as someone actually fixes it. I'm out of time for now, have to move on to other priorities, but I'll keep this on my task list for later.

@Arshia001
Copy link
Member Author

@theduke CI should be green soon, just need an approval to get this merged in

@theduke theduke merged commit 3f5ff85 into master Sep 6, 2023
@theduke theduke deleted the fix-sockets branch September 6, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants