Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid access to wasi instance handles in wasix proc_spawn #4191

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Fix invalid access to wasi instance handles in wasix proc_spawn #4191

merged 1 commit into from
Aug 31, 2023

Conversation

g-bartoszek
Copy link
Contributor

Description

Fixes wasix proc_spawn implementation by removing redundant attempt to retrieve memory from the uninitialized inner handle.

@ptitSeb ptitSeb requested a review from theduke August 30, 2023 15:51
theduke
theduke approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @g-bartoszek !

LGTM

@theduke theduke merged commit 240157c into wasmerio:master Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theduke theduke theduke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g-bartoszek @theduke