Add stdin/stdout/stderr streams to WasiRunner and only use async threading when requested
#4186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-F-Bryan
force-pushed
the
wasi-runner-fixes
branch
from
9702f5c to
9e81e47
Compare
Michael-F-Bryan
force-pushed
the
wasi-runner-fixes
branch
from
9e81e47 to
d3dc6ea
Compare
ptitSeb
approved these changes
Aug 28, 2023
Michael-F-Bryan
force-pushed
the
wasi-runner-fixes
branch
from
d3dc6ea to
2b88305
Compare
Michael-F-Bryan
pushed a commit
to wasmerio/wasmer-js
that referenced
this pull request
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on wasmerio/wasmer-js#328, I noticed that we don't have a way to intercept the stdin, stdout, and stderr streams of a
WasiRunner.I've also made it so we only use async threading when it is explicitly requested. Using async threads in the browser triggers #4158 because it uses things like
task_dedicated()andresume_wasm_after_poller()which may smuggle!Sendtypes to background threads.