Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster compiles for debug by using release version of cranelift #4179

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Faster compiles for debug by using release version of cranelift #4179

merged 2 commits into from
Sep 4, 2023

Conversation

john-sharratt
Copy link
Contributor

@john-sharratt john-sharratt commented Aug 25, 2023 •
edited
Loading

Uses the release version of cranelift for debug as it takes about 5 mins for basic WASM apps on my machine without it.

@theduke
Copy link
Contributor

theduke commented Aug 28, 2023

I already added this ages ago, but @ptitSeb removed it again , I forgot why.

@ptitSeb do you remember the reason?

@theduke theduke requested a review from ptitSeb August 31, 2023 10:43
@ptitSeb
Copy link
Contributor

ptitSeb commented Aug 31, 2023

I already added this ages ago, but @ptitSeb removed it again , I forgot why.

@ptitSeb do you remember the reason?

I don't remember. I think it got lost when I worked on the RISC-V build, but by mystake more then about technicality

@ptitSeb ptitSeb merged commit 037b4bd into master Sep 4, 2023
@ptitSeb ptitSeb deleted the faster-compiles-for-debug branch September 4, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptitSeb ptitSeb ptitSeb approved these changes

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@john-sharratt @theduke @ptitSeb @syrusakbary