Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revive "0-copy module deserialization" #4171

Merged
merged 4 commits into from
Aug 23, 2023
Merged

Revive "0-copy module deserialization" #4171

merged 4 commits into from
Aug 23, 2023

Conversation

Arshia001
Copy link
Member

This reverts commit afa67ff.

@Arshia001 Arshia001 requested a review from syrusakbary as a code owner August 22, 2023 05:43
@Arshia001 Arshia001 requested review from theduke and ptitSeb August 22, 2023 05:44
@Arshia001
Copy link
Member Author

@ptitSeb I believe this has to do with the 4.1.2 update? https://github.com/wasmerio/wasmer/actions/runs/5934934242/job/16092560483?pr=4171

theduke
theduke approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Proper review was done in the previous PR that got reverted.

@theduke
Copy link
Contributor

theduke commented Aug 22, 2023

@Arshia001 I bet you took the Cargo.lock from your branch, and didn't run cargo update?

@Arshia001
Copy link
Member Author

@theduke my changes involved a line in Cargo.toml that referenced the old 4.1.1 version. I've updated that and run cargo update, let's see if any other Cargo.lock files are out of sync as well.

@ptitSeb ptitSeb added this to the v4.2 milestone Aug 22, 2023
@Arshia001 Arshia001 merged commit 5fc8974 into master Aug 23, 2023
@Arshia001 Arshia001 deleted the revive-4139-0-copy-module-deserialization branch August 23, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theduke theduke theduke approved these changes

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

@ptitSeb ptitSeb Awaiting requested review from ptitSeb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Arshia001 @theduke @ptitSeb