fix(cli): Prevent panics in "wasmer login" after API failures #4148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously login_and_save_token() was called from an async context. Since the function uses a blocking reqwest client for the internal GraphQL query, this could lead to panics when the API query failed, due to the blocking reqwest tokio runtime trying to shut down inside another tokio runtime, which is not allowed. This is fixed by running login_and_save_token() inside a spawned thread. Closes #4147
theduke
force-pushed
the
issue-4147-fix-cli-login-panic
branch
from
4e3b8a6 to
a8b66be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously login_and_save_token() was called from an async context.
Since the function uses a blocking reqwest client for the internal
GraphQL query, this could lead to panics when the API query failed, due
to the blocking reqwest tokio runtime trying to shut down inside another
tokio runtime, which is not allowed.
This is fixed by running login_and_save_token() inside a spawned thread.
Closes #4147