Tweak logging annotations to simplify performance troubleshooting #4100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-F-Bryan
changed the title
#[tracing::instrument] annotations to simplify performance troubleshooting
Michael-F-Bryan
force-pushed
the
tweaked-logs
branch
from
e36a001 to
5562177
Compare
theduke
approved these changes
Jul 27, 2023
Michael-F-Bryan
force-pushed
the
tweaked-logs
branch
from
5562177 to
bfa9f39
Compare
Michael-F-Bryan
force-pushed
the
tweaked-logs
branch
from
bfa9f39 to
8b6b352
Compare
Michael-F-Bryan
force-pushed
the
tweaked-logs
branch
from
c4522c5 to
0cbb022
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While analysing the run time for
wasmer run, I made a couple tweaks to our#[tracing::instrument]annotations so theDEBUGlevel logs are less spammy.I also annotated a couple sections of code that weren't previously annotated and added a
--log-formatflag that can be used to switch the log format between text and JSON. I find JSON tends to be easier to read and analyse, especially when you use a Python REPL or withjq.Additionally, I've made main
wasmercrate usetracingunconditionally because it doesn't make much sense to put logging behind a feature flag.