Enable tokio's "net" feature in the virtual-net crate #4068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
virtual-netcrate forgot to enable Tokio'snetfeature wheneverhost-netis enabled, so it won't compile by itself.That seems to be what caused
make test-build-docs-rsto fail onmaster... We only discovered this missing feature flag because #4064 told docs.rs to activate thehost-netfeature, and that test iterates through each crate and builds it with the same feature flags and--cfg=docsrsthat docs.rs would use.This fixes #4066.