Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docstring for MemoryView struct #4063

Merged
merged 1 commit into from
Jul 9, 2023
Merged

Fix docstring for MemoryView struct #4063

merged 1 commit into from
Jul 9, 2023

Conversation

vinnymeller
Copy link
Contributor

It says to use Memory.grow() to get a view, but
Memory.view() is what returns a MemoryView.

@vinnymeller
Fix docstring for MemoryView struct
cd921ad 
It says to use Memory.grow() to get a view, but
Memory.view() is what returns a MemoryView.
@vinnymeller vinnymeller requested a review from syrusakbary as a code owner July 9, 2023 07:45
@ptitSeb ptitSeb enabled auto-merge July 9, 2023 08:51
@ptitSeb
Copy link
Contributor

ptitSeb commented Jul 9, 2023

Good catch, thank you.

@ptitSeb ptitSeb merged commit 07198b9 into wasmerio:master Jul 9, 2023
@vinnymeller vinnymeller deleted the fix-memoryview-docstring branch July 9, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptitSeb ptitSeb ptitSeb approved these changes

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinnymeller @ptitSeb