Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use is-terminal to check tty #4061

Merged
merged 1 commit into from
Jul 8, 2023
Merged

Use is-terminal to check tty #4061

merged 1 commit into from
Jul 8, 2023

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Jul 8, 2023

Description

The motivation is to modernize the way to check tty. Since isatty and atty are not maintained, replaces them with is-terminal crate, which is used by rust ecosystems widely and the api was stabilized as std::io::IsTerminal at Rust 1.70. This reduces dependencies on outdated versions of the libraries they depend on as well.

@tottoto tottoto requested a review from syrusakbary as a code owner July 8, 2023 08:49
theduke
theduke approved these changes Jul 8, 2023
View reviewed changes
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are actually already pulling in is-terminal through the edge CLI, so this is a good call.

@theduke theduke enabled auto-merge July 8, 2023 09:54
@theduke theduke merged commit c02f7a7 into wasmerio:master Jul 8, 2023
@tottoto tottoto deleted the use-is-terminal-to-check-tty branch July 8, 2023 10:29
@tottoto tottoto mentioned this pull request Jul 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theduke theduke theduke approved these changes

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tottoto @theduke