Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup some clippy warnings #406

Merged
merged 2 commits into from
Apr 30, 2019
Merged

Cleanup some clippy warnings #406

merged 2 commits into from
Apr 30, 2019

Conversation

bjfish
Copy link
Contributor

@bjfish bjfish commented Apr 30, 2019

Cleaned up some

  • long literal lacking separators
  • unneeded return

@bjfish
Copy link
Contributor Author

bjfish commented Apr 30, 2019

bors try

bors bot added a commit that referenced this pull request Apr 30, 2019
@bors
Try #406:
80ca8e8
@bors
Copy link
Contributor

bors bot commented Apr 30, 2019

try

Build succeeded

@xmclark xmclark self-requested a review April 30, 2019 15:23
xmclark
xmclark approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@xmclark xmclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@xmclark
Copy link
Contributor

xmclark commented Apr 30, 2019 •
edited
Loading

bors r+

1 similar comment
@xmclark
Copy link
Contributor

xmclark commented Apr 30, 2019

bors r+

bors bot added a commit that referenced this pull request Apr 30, 2019
@bors @bjfish
Merge #404 #406
82cf572 
404: Update to newer common wasmparser version r=xmclark a=bjfish

- versions should match to have matching types in a common parser
- the `0.29.2` version matches the current parser version of cranelift-wasm

406: Cleanup some clippy warnings r=xmclark a=bjfish

Cleaned up some
- long literal lacking separators
- unneeded return

Co-authored-by: Brandon Fish <[email protected]>
@bors
Copy link
Contributor

bors bot commented Apr 30, 2019

Build succeeded

@bors bors bot merged commit 01ba789 into master Apr 30, 2019
@bors bors bot deleted the fix/cleanup-some-clippy-warning branch April 30, 2019 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmclark xmclark xmclark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjfish @xmclark