-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
login with browser using nonce #4057
Conversation
…apabilites backwards compatibility
Comments:
If the user cancels the auth in the browser, the output should be:
If the user takes more than (10 mins? ask @ayys) to complete, the output should be:
|
Yup, nonces expire after 1- minutes (configurable via Doppler) |
@syrusakbary the behaviour exists on |
We should set it to 5 mins min? 1 min seems very quick |
What behavior are you referring to? |
$ wasmer login --registry https://registry.wasmer.wtf/graphql
Server URL: http://localhost:64307
Opening browser at https://frontend-git-add-auth-flow-for-the-wasmer-cli-frontend-wapm.vercel.app/auth/cli?nonce_id=nnc_YIZteiOYR&secret=R2diNa5dcXzbJ9abCotp7-Eorag
Token: wap_f77d01da79caad37f7e1553850b271c2b61b***
Shutting down server
Login for Wasmer user "xorcist" saved |
Missing:
|
Texts as suggestions means: text as I suggested in a previous comment: #4057 (comment) |
AuthorizationState::TokenSuccess(token) => { | ||
assert_eq!( | ||
token, | ||
"Please paste the login token from https://wasmer.wtf/settings/access-tokens" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be wasmer.io not wtf ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are tests @syrusakbary
…io/wasmer into cli-login-through-browser
…login-through-browser
closes #4034 |
Initially we would login from the
wasmer-cli
using thewasmer login
command which would in turn ask for the token.For this token a person would explicitly had to go to the wasmer registry make a token, then come back and save the token in the CLI. this is very unpleasant in terms of DX.