Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the integration tests #4038

Merged
merged 17 commits into from
Jul 24, 2023
Merged

Conversation

Michael-F-Bryan
Copy link
Contributor

@Michael-F-Bryan Michael-F-Bryan commented Jun 27, 2023

This PR does a couple things to make our CLI integration test story a bit nicer:

  • The run-unstable integration tests have been merged into run.rs because wasmer run-unstable no longer exists
  • We now use the --registry flag from Added a WasmerEnv abstraction to the CLI #4013 instead of running wasmer login and clobbering the tokens in the user's $WASMER_DIR/wasmer.toml (Fixes The wasmer-integration-tests-cli test suite isn't hygienic #4015)
  • The run-unstable tests now run the wasmer executable directly instead of making a defensive cargo run --features=...
  • Some create-exe tests were moved from run.rs into create_exe.rs where they belong
  • Moved the paths for all files used during testing into a single fixtures module
  • Remove the --test-threads=1 from make test-integration-cli so we use all cores when running integration tests
  • Remove the --no-capture from make test-integration-cli to reduce the amount of spam you are bombarded with when running tests

After these changes, the "Test Integration CLI" CI step is reduced from taking about 30 minutes to 3 minutes.

It also looks like the MUSL segfaults are gone (i.e. fixes #3698).

@Michael-F-Bryan Michael-F-Bryan force-pushed the hygienic-integration-tests branch from b3bf384 to f5306dc Compare June 27, 2023 05:10
@Michael-F-Bryan Michael-F-Bryan marked this pull request as ready for review June 27, 2023 05:10
@Michael-F-Bryan Michael-F-Bryan disabled auto-merge June 27, 2023 05:26
@Michael-F-Bryan Michael-F-Bryan force-pushed the hygienic-integration-tests branch from 8a6318e to b01249e Compare June 28, 2023 05:00
@Michael-F-Bryan Michael-F-Bryan force-pushed the hygienic-integration-tests branch from de8ae10 to 756afd6 Compare June 28, 2023 08:23
Makefile Outdated Show resolved Hide resolved
@Michael-F-Bryan Michael-F-Bryan force-pushed the hygienic-integration-tests branch from 756afd6 to c82effc Compare July 10, 2023 02:40
@Michael-F-Bryan
Copy link
Contributor Author

Michael-F-Bryan commented Jul 10, 2023

I'm going to put this PR on hold until #4050 is merged.

We're seeing a bunch of new runtime-related issues in the snapshot tests, which doesn't really make sense this PR hasn't touched any code in the main wasmer-wasix crate. Hopefully they're just spurious failures due to non-determinism and bugs, and the epoll PR will fix things 🤞

@Michael-F-Bryan Michael-F-Bryan force-pushed the hygienic-integration-tests branch from c82effc to 5b45ab4 Compare July 24, 2023 06:35
@Michael-F-Bryan Michael-F-Bryan merged commit b9ad3f4 into master Jul 24, 2023
@Michael-F-Bryan Michael-F-Bryan deleted the hygienic-integration-tests branch July 24, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants