-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up the integration tests #4038
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-F-Bryan
force-pushed
the
hygienic-integration-tests
branch
from
June 27, 2023 05:10
b3bf384
to
f5306dc
Compare
ptitSeb
reviewed
Jun 27, 2023
ptitSeb
reviewed
Jun 27, 2023
ptitSeb
approved these changes
Jun 27, 2023
ptitSeb
reviewed
Jun 27, 2023
Michael-F-Bryan
force-pushed
the
hygienic-integration-tests
branch
from
June 28, 2023 05:00
8a6318e
to
b01249e
Compare
Michael-F-Bryan
force-pushed
the
hygienic-integration-tests
branch
from
June 28, 2023 08:23
de8ae10
to
756afd6
Compare
syrusakbary
reviewed
Jun 28, 2023
Michael-F-Bryan
force-pushed
the
hygienic-integration-tests
branch
from
July 10, 2023 02:40
756afd6
to
c82effc
Compare
I'm going to put this PR on hold until #4050 is merged. We're seeing a bunch of new runtime-related issues in the snapshot tests, which doesn't really make sense this PR hasn't touched any code in the main |
…ves because it uses the global cache
Michael-F-Bryan
force-pushed
the
hygienic-integration-tests
branch
from
July 24, 2023 06:35
c82effc
to
5b45ab4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a couple things to make our CLI integration test story a bit nicer:
run.rs
becausewasmer run-unstable
no longer exists--registry
flag from Added aWasmerEnv
abstraction to the CLI #4013 instead of runningwasmer login
and clobbering the tokens in the user's$WASMER_DIR/wasmer.toml
(Fixes Thewasmer-integration-tests-cli
test suite isn't hygienic #4015)wasmer
executable directly instead of making a defensivecargo run --features=...
cargo run
doesn't make sense any more because Make CLI integration tests automatically run the most up-to-date version of the CLI #4020 decided that we'll rely onmake integration-test-cli
or the user to provide an up-to-datewasmer
executablerun.rs
intocreate_exe.rs
where they belongfixtures
module--test-threads=1
frommake test-integration-cli
so we use all cores when running integration tests--no-capture
frommake test-integration-cli
to reduce the amount of spam you are bombarded with when running testsAfter these changes, the "Test Integration CLI" CI step is reduced from taking about 30 minutes to 3 minutes.
It also looks like the MUSL segfaults are gone (i.e. fixes #3698).