Canonicalize the host path passed to --mapdir
#4018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-F-Bryan
force-pushed
the
mapdir-relative-paths
branch
from
3439da5 to
5df6e63
Compare
ptitSeb
approved these changes
Jun 21, 2023
theduke
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
I thought some of my additions already added always canonicalizing to an absolute path , at least in the WASI runner.
But it makes sense to move this a bit higher up.
As mentioned previously, I don't think it makes any sense to have relative paths here apart from the CLI argument phase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR patches the logic for
--mapdirso we always use absolute paths when mounting directories.Ideally we wouldn't need to do this canonicalizing because the code for mounting directories should be able to handle relative paths, but this quickfix should resolve things until we do our big filesystem layer overhaul.
Fixes #4010.