-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extending WASI plugin example #399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! This was needed.
I made some feedback. The only other suggestion is adding a wapm.toml
. We may not publish it, but it is still good for people to see wapm in the wild ™️ .
# build it | ||
cargo build --release --target=wasm32-unknown-wasi | ||
# copy it to examples folder | ||
cp ../../target/wasm32-unknown-wasi/release/plugin-for-example.wasm ../ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may also be worth noting that WASI is only supported on windows with the gnu toolchain. If you can't find a way to work this detail into the example, that's ok, but it could be another stumbling block for some.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'm not sure exactly what to add to say that. What I mean is, does that show up in the target
dir?
Co-Authored-By: MarkMcCaskey <[email protected]>
Co-Authored-By: MarkMcCaskey <[email protected]>
Co-Authored-By: MarkMcCaskey <[email protected]>
…smerio/wasmer into feature/extending-wasi-plugin-example
bors r+ |
399: Add extending WASI plugin example r=MarkMcCaskey a=MarkMcCaskey Co-authored-by: Mark McCaskey <[email protected]> Co-authored-by: Mark McCaskey <[email protected]> Co-authored-by: Mackenzie Clark <[email protected]>
…url-to-the-worker-bootstrap-script-via-the Pass the import URL to the worker bootstrap script via the `init` message
No description provided.